comments

histream-import/src/main/java/de/sekmi/histream/etl/config/Concept.java

@@ -150,6 +150,7 @@ public class Concept{
 					concept = mf.getConceptOverride();
 				}
 				// or drop the modifier
+				// TODO how to specify that a modifier should be dropped (e.g. if the value is NA)???
 				if( mf.isActionDrop() ){
 					continue; // ignore this modifier
 				}

histream-import/src/main/java/de/sekmi/histream/etl/config/EavTable.java

@@ -75,6 +75,10 @@ public class EavTable extends Table<EavRow> {
 		ColumnMap map = new ColumnMap(headers);
 		if( idat.patientId == null ){
 			throw new ParseException("datasource/eav-table/idat/patient-id column not specified");
+			// TODO allow missing patient id, similar to WideTable.java
+			// missing patient id is allowed, for cases 
+			// when the visit id is unique and sufficient for matching
+
 		}
 		if( idat.visitId == null ){
 			throw new ParseException("datasource/eav-table/idat/visit-id column not specified");